mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 53704: Added a level of indirection for logger through IO Switchboard.
Date Tue, 15 Nov 2016 23:50:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53704/
-----------------------------------------------------------

(Updated Nov. 15, 2016, 11:50 p.m.)


Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Changes
-------

Moved to `io_switchboard.*` files to new directory in preparation of new `main.hpp` and `main.cpp`
files for the io-switchboard process.


Bugs: MESOS-6467
    https://issues.apache.org/jira/browse/MESOS-6467


Repository: mesos


Description
-------

We are adding a new component to the mesos containerizer called
IOSwitchboard. The purpose of this component is to feed stdin to a
container from an external source, as well as redirect the
stdin/stdout of a container to multiple targets.

The primary motivation of this component is to enable support in mesos
similar to 'docker attach' and 'docker exec' whereby an external
client can attach to the stdin/stdout/stderr of a running container as
well as launch arbitrary subcommands inside a container and attach to
its stdin/stdout/stderr.

to enable this functionatlity, we also introduce a new
IOSwitchboardProcess in this commit (although it is not strictly
necessary). We will be adding additional functionality that relies on
it in subsequent commits.


Diffs (updated)
-----

  src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
  src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac 
  src/slave/containerizer/mesos/containerizer.hpp 272052ddf85b50f817a110a9a83566b011598985

  src/slave/containerizer/mesos/containerizer.cpp ec4ae32485a7ab6c9f73c512004d1220482a188e

  src/slave/containerizer/mesos/io_switchboard/io_switchboard.hpp PRE-CREATION 
  src/slave/containerizer/mesos/io_switchboard/io_switchboard.cpp PRE-CREATION 
  src/tests/containerizer/docker_volume_isolator_tests.cpp 2f21b49535856186e153cd299dd1eda11495fa17

  src/tests/containerizer/mesos_containerizer_tests.cpp 5aae23b1b470d5323ecc21fb5df7ad8ae2498dfa


Diff: https://reviews.apache.org/r/53704/diff/


Testing
-------

GTEST_FILTER="" make -j check
sudo src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message