mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Re: Review Request 50498: Added --master_pid_group flag in master.
Date Mon, 14 Nov 2016 04:03:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50498/
-----------------------------------------------------------

(Updated Nov. 14, 2016, 4:03 a.m.)


Review request for mesos and Joseph Wu.


Changes
-------

rebase


Summary (updated)
-----------------

Added --master_pid_group flag in master.


Bugs: MESOS-5829
    https://issues.apache.org/jira/browse/MESOS-5829


Repository: mesos


Description (updated)
-------

Added --master_pid_group flag to pass in pid_group module name.
Necessary validation logic is added to master/main.cpp.


Diffs (updated)
-----

  src/master/flags.hpp 6a17b763dc76daa10073394f416b049e97a44238 
  src/master/flags.cpp 9bfb40e22820c3ced40b128280ec63288fea8b41 
  src/master/main.cpp 2d2dfb7d632f3c7be1796efd8f0a1f4d18760261 

Diff: https://reviews.apache.org/r/50498/diff/


Testing
-------

see end of review chain.


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message