mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
Date Sat, 12 Nov 2016 14:39:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/#review155782
-----------------------------------------------------------




src/tests/containerizer/docker_containerizer_tests.cpp (line 4102)
<https://reviews.apache.org/r/50127/#comment225868>

    s/1/one



src/tests/containerizer/docker_containerizer_tests.cpp (line 4192)
<https://reviews.apache.org/r/50127/#comment225869>

    s/priviledged/priviledged mode



src/tests/containerizer/docker_containerizer_tests.cpp (lines 4226 - 4229)
<https://reviews.apache.org/r/50127/#comment225870>

    ```
    // We use `docker inspect` to verify that all injected nvidia devices
    // are presented inside the running docker container. This includes
    // both the control devices (e.g. `/dev/nvidia-uvm`) as well as the GPU
    // device itself (i.e. `/dev/nvidia0`).
    ```


- Guangya Liu


On 十一月 10, 2016, 8:15 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50127/
> -----------------------------------------------------------
> 
> (Updated 十一月 10, 2016, 8:15 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This added a testing case for end-to-end GPU support for docker
> containerizer.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16

> 
> Diff: https://reviews.apache.org/r/50127/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message