mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 52787: Reorganized the work directory and the runtime directory in local mode.
Date Wed, 09 Nov 2016 16:55:42 GMT


> On Nov. 3, 2016, 3:55 p.m., Kevin Klues wrote:
> > src/local/flags.hpp, lines 35-52
> > <https://reviews.apache.org/r/52787/diff/5/?file=1539020#file1539020line35>
> >
> >     I don't think we should have a flag for `temp_dir` here. We should still have
separate flags for  `work_dir` and `runtime_dir`.
> >     
> >     With those, you can still organize things similar to what you've described above,
but each should be rooted differently, i.e.:
> >     
> >     ```
> >     /tmp/mesos/work
> >     |-- master
> >     |   |-- replicated_log
> >     |   |   |-- 000004.log
> >     |   |   |-- CURRENT
> >     |   |   |-- LOCK
> >     |   |   |-- LOG
> >     |   |   |-- MANIFEST-000002
> >     |-- agents
> >         |-- 0
> >         |   |-- meta
> >         |   |   |-- boot_id
> >         |   |   |-- slaves
> >         |   |       |-- 5b7cf084-32d7-4530-8451-d6e5db19f48f-S0
> >         |   |       |   |-- slave.info
> >         |   |       |-- latest -> /tmp/mesos/work/meta/slaves/5b7cf084-32d7-4530-8451-d6e5db19f48f-S0
> >         |   |-- provisioner
> >         |-- 1
> >             |-- meta
> >             |   |-- boot_id
> >             |   |-- slaves
> >             |       |-- 5b7cf084-32d7-4530-8451-d6e5db19f48f-S1
> >             |       |   |-- slave.info
> >             |       |-- latest -> /tmp/mesos/work/meta/slaves/5b7cf084-32d7-4530-8451-d6e5db19f48f-S1
> >             |-- provisioner
> >     
> >                 
> >     /tmp/mesos/runtime
> >     |-- agents
> >         |-- 0
> >         |   |-- runtime_dir
> >         |-- 1
> >             |-- runtime_dir
> >     ```

Thanks a lot, may you help review this patch again? I update the structure as you suggested.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52787/#review154738
-----------------------------------------------------------


On Nov. 9, 2016, 4:53 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52787/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6380
>     https://issues.apache.org/jira/browse/MESOS-6380
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Reorganized the work directory and the runtime directory in local mode.
> 
> 
> Diffs
> -----
> 
>   bin/mesos-local-flags.sh.in 5b4553a808dc9f34a15390e69b2f85e95761ec53 
>   src/local/flags.hpp 3d8e5392f770a72354215829022b677caee9d8c6 
>   src/local/local.cpp 257179443827ffdfc946ed655a6840fcea70d454 
> 
> Diff: https://reviews.apache.org/r/52787/diff/
> 
> 
> Testing
> -------
> 
> No matter use `bin/mesos-local.sh` or use `src/mesos-local`, the folder structure looks
like
> 
> ```
> $ tree /tmp/mesos/
> /tmp/mesos/
> |-- runtime
> |   |-- agents
> |       |-- 0
> |       |-- 1
> |-- work
>     |-- agents
>     |   |-- 0
>     |   |   |-- meta
>     |   |   |   |-- boot_id
>     |   |   |   |-- slaves
>     |   |   |       |-- a63fbc0a-268e-4ebe-b31c-90d3a19d2fb3-S0
>     |   |   |       |   |-- slave.info
>     |   |   |       |-- latest -> /tmp/mesos/work/agents/0/meta/slaves/a63fbc0a-268e-4ebe-b31c-90d3a19d2fb3-S0
>     |   |   |-- provisioner
>     |   |-- 1
>     |       |-- meta
>     |       |   |-- boot_id
>     |       |   |-- slaves
>     |       |       |-- b4d008bc-6be4-4bba-97c3-3a73d3f9611d-S0
>     |       |       |   |-- slave.info
>     |       |       |-- latest -> /tmp/mesos/work/agents/1/meta/slaves/b4d008bc-6be4-4bba-97c3-3a73d3f9611d-S0
>     |       |-- provisioner
>     |-- master
>         |-- replicated_log
>             |-- 000009.log
>             |-- 000011.sst
>             |-- CURRENT
>             |-- LOCK
>             |-- LOG
>             |-- LOG.old
>             |-- MANIFEST-000006
> 
> 20 directories, 11 files
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message