mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <>
Subject Re: Review Request 53540: Tweaked parameter names in Mesos.
Date Mon, 07 Nov 2016 16:15:28 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 7, 2016, 4:15 p.m.)

Review request for mesos, Benjamin Bannier and Michael Park.


Address review comments.

Repository: mesos


Ensure consistency between declaration and definition. Spotted via

Diffs (updated)

  include/mesos/state/protobuf.hpp 47beb45ecb9d3486e9f8f8ce38d48264f512107d 
  src/common/http.hpp c2398177c9e5af12c7a20c02e92d3f3036a7a39a 
  src/common/protobuf_utils.cpp 7362b875ce1ffca6bc6376169a11494bdb9cf062 
  src/linux/capabilities.hpp 9c0bcf46c1bf8435eabb7410961ce52828ffbfea 
  src/linux/capabilities.cpp 3e30c4d8966246778d59245794885139e9d14dfe 
  src/log/coordinator.hpp b5f9c962a983af0d591e878d12b7fe8bb59cc867 
  src/master/master.hpp 87186c6e733a686f96528b1722fda1c287e9c881 
  src/master/master.cpp 15ad5a647fc71d36ffd149893b3b9448a7d99323 
  src/slave/slave.hpp c0a17657e684e87d555731d2e35ac15894c3c05b 
  src/slave/slave.cpp d6c337345707993b0729e9eaf36b5a9ecc52dc72 
  src/tests/utils.cpp fc004a9c567898ffbc38a42cc2340dd57347a829 



`make check`

Note that there are lots of other mismatches in names between declarations and definitions,
but most of the ones I didn't fix seem to be intentional: e.g., declaring a parameter named
`t` but using `t_` in the definition (typically because the implementation assigns `t_` to
a member field named `t`).


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message