mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 53536: Avoided unnecessary copy in stout.
Date Mon, 07 Nov 2016 16:08:39 GMT


> On Nov. 7, 2016, 3:56 p.m., Benjamin Bannier wrote:
> > As an aside, how did you use `support/mesos-tidy.sh` with custom `CHECKS` to find
these, or just run plain `clang-tidy` on the files in the compilation database? I am asking
since stout is a header-only library, and that with some `header-filter` there could be more
issues in header files. Or else the code is just very clean ...
> 
> Benjamin Bannier wrote:
>     One more thing. As you go through and fix lint categories, it would be great if you
could globally enable fixed clang-tidy checks in https://github.com/apache/mesos/blob/bda1194e7b5b2c6f145d1f4b4bc22c5132bfca1d/support/mesos-tidy.sh#L29.

I just ran `docker run -e CHECKS=...` with various custom checks enabled.

Agreed on eventually adding more checks to the default list, but I was hoping to get us down
to 0 `clang-tidy` warnings before I add more checks to the list :) There are still a few more
warnings to address with the current set of checks. It would also be nice to update the docker
image to use clang 3.9, since that apparently added a bunch of new checks over 3.8.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53536/#review155148
-----------------------------------------------------------


On Nov. 7, 2016, 3:24 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53536/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2016, 3:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Spotted via clang-tidy.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/os_tests.cpp 0b7ee0723b6a608d6f110fa8ac16e0fd7b75ddea 
> 
> Diff: https://reviews.apache.org/r/53536/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message