mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 53266: Fixed `DefaultExecutorTest.*` tests on hosts without Docker.
Date Fri, 04 Nov 2016 17:12:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53266/
-----------------------------------------------------------

(Updated Nov. 4, 2016, 5:12 p.m.)


Review request for mesos, Till Toenshoff, Vinod Kone, and Jiang Yan Xu.


Changes
-------

Addressed all the feedback.


Summary (updated)
-----------------

Fixed `DefaultExecutorTest.*` tests on hosts without Docker.


Bugs: MESOS-6455
    https://issues.apache.org/jira/browse/MESOS-6455


Repository: mesos


Description (updated)
-------

Some of the tests are parameterized by the containerizers.

Fixed the naming schema, so that the tests using the Docker
containerizer run only if Docker is available.

Now the tests with the Mesos containerizer also run if the tests
are started as a non-root user.


Diffs (updated)
-----

  src/tests/default_executor_tests.cpp db953d39a95e7e95871054114a0a9bbeded46224 

Diff: https://reviews.apache.org/r/53266/diff/


Testing (updated)
-------

`sudo bin/mesos-tests.sh --gtest_filter='*DefaultExecutorTest*' --docker=/tmp/foo`
`sudo bin/mesos-tests.sh --gtest_filter='*DefaultExecutorTest*'`
`bin/mesos-tests.sh --gtest_filter='*DefaultExecutorTest*'`


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message