mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.
Date Thu, 03 Nov 2016 15:53:29 GMT


> On Nov. 1, 2016, 10:08 p.m., Jie Yu wrote:
> > The agent subsystems is a hack to me. I think we should consider support running
systemd (or other init system) to manage agent process and put it under proper cgroup using
the init system, rather than doing it ourself.
> 
> Anindya Sinha wrote:
>     Agreed. But since this flag exists, I think we should address this condition? Or
are you suggesting to deprecate this flag?

@Jie

If you are talking about the Mesos core, I think it already supports being run by systemd?
If you are talking about supporting scripts/configs/packaging, then I agree the project can
potentially do more but that's a longer term goal towards better user experience of "stock"
Mesos packages. 

In the meantime, the flag has been here for a long time and we'd like to fix this bug with
it. Sounds good?


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53369/#review154512
-----------------------------------------------------------


On Nov. 1, 2016, 9:43 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53369/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6523
>     https://issues.apache.org/jira/browse/MESOS-6523
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is to ensure that we do not accept traffic on the agent by opening
> up libprocess port only after cgroup assigment for the agent is done.
> 
> 
> Diffs
> -----
> 
>   src/slave/main.cpp 8010f8e229e2d820649750c9db0456ecd1b854d3 
>   src/slave/slave.cpp d6c337345707993b0729e9eaf36b5a9ecc52dc72 
> 
> Diff: https://reviews.apache.org/r/53369/diff/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message