mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 52828: Allow the chown code in fetcher to be executed.
Date Wed, 02 Nov 2016 23:49:48 GMT


> On Nov. 2, 2016, 10:36 p.m., Joseph Wu wrote:
> > src/slave/containerizer/fetcher.cpp, lines 788-790
> > <https://reviews.apache.org/r/52828/diff/3/?file=1538261#file1538261line788>
> >
> >     This short-circuit leaks the two FDs opened above.

RR for this fix: https://reviews.apache.org/r/53413


- Anindya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52828/#review154647
-----------------------------------------------------------


On Oct. 14, 2016, 6:14 p.m., Megha Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52828/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2016, 6:14 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: mesos-5218
>     https://issues.apache.org/jira/browse/mesos-5218
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved the uri.size() check in fetcher so that the chown to
> task user of stdout/stderr in sandbox directory happens even
> when there is no uri to be fetched.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/fetcher.cpp 11104d66e6dd05d8eb1d37a2e3250aca19278110 
>   src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc 
> 
> Diff: https://reviews.apache.org/r/52828/diff/
> 
> 
> Testing
> -------
> 
> make check on macOs and linux
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message