mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 53378: Fixed the command executor to not generate RUNNING after KILLING.
Date Wed, 02 Nov 2016 21:51:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53378/
-----------------------------------------------------------

(Updated Nov. 2, 2016, 9:51 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Changes
-------

Rebased + changed the patches breakdown.


Summary (updated)
-----------------

Fixed the command executor to not generate RUNNING after KILLING.


Bugs: MESOS-6457
    https://issues.apache.org/jira/browse/MESOS-6457


Repository: mesos


Description (updated)
-------

The command executor would send health updates even after having
transitioned a task to `TASK_KILLING`. This plus the fact that health
updates always have the `TASK_RUNNING` state leads to `TASK_KILLING ->
TASK_RUNNING` transitions.

This patch makes the executor skip health updates after starting to kill
a task.


Diffs (updated)
-----

  src/launcher/executor.cpp 0544121e679db503fe4eaf23a24e315eb188a520 

Diff: https://reviews.apache.org/r/53378/diff/


Testing (updated)
-------

Test in the next patch in the chain.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message