mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 53361: Fixed memory leak in request/response decoders.
Date Wed, 02 Nov 2016 03:25:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53361/#review154499
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/decoder.hpp (line 278)
<https://reviews.apache.org/r/53361/#comment224080>

    Seems we need to also delete these requests? Ditto for the other deques.


- Benjamin Mahler


On Nov. 2, 2016, 12:20 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53361/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6527
>     https://issues.apache.org/jira/browse/MESOS-6527
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The leak can happen in cases where a client disconnects while the
> request/response is in progress.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/decoder.hpp c79296bc50e5bf5adf9f2c62114bef83bb183f79 
> 
> Diff: https://reviews.apache.org/r/53361/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message