mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 53304: Fixed parallel test runner for empty GTEST_FILTER.
Date Mon, 31 Oct 2016 16:45:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53304/#review154276
-----------------------------------------------------------


Ship it!




Ship It!

- Neil Conway


On Oct. 31, 2016, 4:04 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53304/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2016, 4:04 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-6516
>     https://issues.apache.org/jira/browse/MESOS-6516
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We need to correctly distinguish between the environment variable
> GTEST_FILTER being unset, and containing an empty string. In the first
> case we want to run all tests, while in the latter only the explicitly
> requested set.
> 
> 
> Diffs
> -----
> 
>   support/mesos-gtest-runner.py 457211a7721a1595a8efaf51a10041da0494bdfe 
> 
> Diff: https://reviews.apache.org/r/53304/diff/
> 
> 
> Testing
> -------
> 
> Created a failing test and confirmed it was not executed when `GTEST_FILTER=''` was set
in the environment.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message