mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 53202: Avoided CHECK failure with pre-1.0 agents.
Date Thu, 27 Oct 2016 17:16:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53202/
-----------------------------------------------------------

(Updated Oct. 27, 2016, 5:16 p.m.)


Review request for mesos, Vinod Kone and Jiang Yan Xu.


Changes
-------

Add a warning message if partition-awareness cannot be determined accurately.


Bugs: MESOS-6483
    https://issues.apache.org/jira/browse/MESOS-6483


Repository: mesos


Description
-------

We don't guarantee compatibility with pre-1.0 agents. However, since it
is easy to avoid a CHECK failure in the master when an old agent
re-registers, it seems worth doing so.


Diffs (updated)
-----

  src/master/master.cpp 23ddb995b4ad0fcdb589974308a2e81ececdad31 

Diff: https://reviews.apache.org/r/53202/diff/


Testing
-------

`make check`

Disabled the code that fills-in `frameworks.recovered`; verified that `PartitionTest.DisconnectedFramework`
dies with a `CHECK` failure if this RR is not applied but passes this with RR applied.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message