mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 53172: Fixed the broken metrics information of master in WebUI.
Date Thu, 27 Oct 2016 04:10:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53172/
-----------------------------------------------------------

(Updated Oct. 27, 2016, 4:10 a.m.)


Review request for mesos, Joseph Wu, Vinod Kone, and Jiang Yan Xu.


Changes
-------

Address @vinodkone's comments.


Bugs: MESOS-6446
    https://issues.apache.org/jira/browse/MESOS-6446


Repository: mesos


Description
-------

After introduced redirection on `/master/state` endpoint to the leading
master in `c9153336`, the manual redirection logic in WebUI in broken
because browser would redirect requests automatically when receives
`307 Temporary Redirect`. Because the metrics information for tasks is
only available on the leading master, it would miss in WebUI if the
master we accessed is not a leading master. In this patch, we retrieve
the leading master from `/master/state` endpoint and ensure the
requests to `/metrics/snapshot` endpoint always send to the leading
master.


Diffs (updated)
-----

  src/webui/master/static/js/controllers.js 3dead4f20e2dbeec8447e22ad287dd6ed2378345 

Diff: https://reviews.apache.org/r/53172/diff/


Testing
-------

...


Test screen record.

![webui_metrics](https://issues.apache.org/jira/secure/attachment/12835172/webui_metrics.gif)


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message