mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood <aaron.w...@verizon.com>
Subject Re: Review Request 52645: Harden Mesos
Date Tue, 25 Oct 2016 16:08:03 GMT


> On Oct. 24, 2016, 5:50 p.m., James Peach wrote:
> > src/Makefile.am, line 114
> > <https://reviews.apache.org/r/52645/diff/5/?file=1529823#file1529823line114>
> >
> >     I wasn't able to figure this line out, so it probably needs a comment to explain
where ``VARIANTS`` comes from and what this filtering is doing.

I need to fix this. I wrongly thought `VARIANTS` was something that was set elsewhere. I'll
apply the appropriate flags in another way. Ideally this was supposed to apply `-fPIC` and
`-fPIE` only to shared libs.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52645/#review153713
-----------------------------------------------------------


On Oct. 21, 2016, 6:31 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52645/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2016, 6:31 p.m.)
> 
> 
> Review request for mesos, James Peach, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-6229
>     https://issues.apache.org/jira/browse/MESOS-6229
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use a default set of flags to provide additional security and hardening to Mesos. Additionally,
check and catch more warnings/errors.
> 
> 
> Diffs
> -----
> 
>   configure.ac 034bb91 
>   src/Makefile.am fd01e1d 
> 
> Diff: https://reviews.apache.org/r/52645/diff/
> 
> 
> Testing
> -------
> 
> Compared the benchmarks with and without the flags being used. Also did a comparsion
with the flags being used with and without optimizations and without the flags being used
with and without optimizations. Overall the performance hit was very small with a 3-8% overhead
(optimizations brings this down slightly). Most benchmarks were about 5% (or less) slower.
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message