mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 53053: Divided utils.hpp to utils.hpp and utils.cpp.
Date Tue, 25 Oct 2016 03:43:57 GMT


> On Oct. 24, 2016, 11:25 a.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/utils.cpp, lines 25-38
> > <https://reviews.apache.org/r/53053/diff/3/?file=1543728#file1543728line25>
> >
> >     Any specific reason this change is part of this patch? We should probably have
a separate patch for this change. Don't think it has anything to do with with whiteout conversion.
> >     
> >     Also, don't think we support nested containers on anything other than linux
at this point

Agree, I have separated it.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53053/#review153655
-----------------------------------------------------------


On Oct. 25, 2016, 11:43 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53053/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2016, 11:43 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6360
>     https://issues.apache.org/jira/browse/MESOS-6360
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Divided utils.hpp to utils.hpp and utils.cpp.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 769e998d80fde17bcb1ee6c5091ce13a1ad16137 
>   src/slave/containerizer/mesos/utils.hpp 178ebf3effac824e4788d7282795c18dc1cb5265 
>   src/slave/containerizer/mesos/utils.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53053/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message