mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 53112: Fixed flakiness in `MasterTest.UnreachableTaskAfterFailover`.
Date Mon, 24 Oct 2016 16:58:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53112/#review153702
-----------------------------------------------------------



Didn't you rebase before post the patch?

- haosdent huang


On Oct. 22, 2016, 6:59 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53112/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2016, 6:59 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also cleanup some test code along the way.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 905a34bb13c2fcd1b22ef4e9605405ef84711c25 
>   include/mesos/slave/containerizer.proto f4c4ad771b5dead4ea3ee7cd1b4383c4dc2359b4 
>   include/mesos/type_utils.hpp 7824407a6bbfc06edeec69479ed82cabae34a440 
>   include/mesos/v1/mesos.proto b72069a6caff0b163d9d9cae45c3caa0b25de38f 
>   src/CMakeLists.txt 639f8678ba23c4d9a2ea0bf84fbc3d6fc9286ef3 
>   src/Makefile.am 769e998d80fde17bcb1ee6c5091ce13a1ad16137 
>   src/common/parse.hpp 0479a54a7bdeb34163ad988959b17f635dcea584 
>   src/common/type_utils.cpp 8270f808277d84a73823992c639d6536a99353b8 
>   src/posix/rlimits.hpp 0cc4d8aa58e400c0509969acdb5bd30bf89146da 
>   src/posix/rlimits.cpp 6446c1418349a0c3cb12d66db7d607e4cf06662d 
>   src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2

>   src/slave/containerizer/mesos/isolators/posix/rlimits.hpp ee36a24ae36179d3ff3141f8c3cdc768b1e399af

>   src/slave/containerizer/mesos/isolators/posix/rlimits.cpp 3fc2b3dbd5b382e422c948adae0dc50f4fbcfc49

>   src/slave/containerizer/mesos/launch.hpp 8b23c1b6df6bc1fdd987af5a4469664356e7f27a 
>   src/slave/containerizer/mesos/launch.cpp 377a9d94aa780ab598b1c2034c10ce25a4e02cbe 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp c20e7fbc1a06296a003b1e4feef6c3477c83cf7f

>   src/tests/master_tests.cpp 9963a0cb360f1e72c17c5a6e75bb88b17cdee467 
>   src/v1/mesos.cpp 5b89603e1b760256c584a188e93be31eeaea7ce2 
>   src/v1/parse.hpp 86bd7e850ae7a17ed3f48300af1b047a877739c3 
> 
> Diff: https://reviews.apache.org/r/53112/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> `mesos-tests --gtest_filter=MasterTest.UnreachableTaskAfterFailover --gtest_repeat=1000
--gtest_break_on_failure`
> 
> Note that I couldn't repro the original test flakiness on my local machine, but from
the log (https://builds.apache.org/job/mesos-reviewbot/15778), this seems to be the problem.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message