mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 53099: Avoided passing `TimeInfo` by value.
Date Fri, 21 Oct 2016 19:37:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53099/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

Although this is likely to remain small in practice, passing by const
reference should be preferred until there is a reason not to.


Diffs
-----

  src/master/master.hpp 6d2db9de52d35f3288c618d05138413ce709818b 
  src/master/master.cpp 3f3ce93155069dd32731783ac4877ba6ee2519c0 

Diff: https://reviews.apache.org/r/53099/diff/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message