mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 51031: Added non-recursive version of `cgroups::get`.
Date Fri, 21 Oct 2016 10:17:00 GMT


> On Oct. 20, 2016, 8:50 p.m., Jie Yu wrote:
> > src/tests/containerizer/cgroups_tests.cpp, line 412
> > <https://reviews.apache.org/r/51031/diff/14/?file=1541970#file1541970line412>
> >
> >     Who remove the cgroup created above?
> 
> Jiang Yan Xu wrote:
>     Hmm, the intention is to have them destroyed in teardown but I guess these cgroups
don't start with `TEST_CGROUPS_ROOT`. I'll add back these removal lines and we can think about
how to do auto-cleanup better.
> 
> haosdent huang wrote:
>     Because
>     
>     ```
>     const static std::string TEST_CGROUPS_ROOT = "mesos_test";
>     ```
>     
>     these cgroups would be clear during the teardown as well. Let me to make this more
clear.
> 
> Jiang Yan Xu wrote:
>     Oh I see, but this feels totally non-obvious: The test itself doesn't use the variable
`TEST_CGROUPS_ROOT` but it expects TearDown to use it.
>     
>     A couple of other tests do this as well. Maybe we'll just do the old way of removing
these cgroups in the test itself and do another sweep to do auto-cleanup better?

Following patch is https://reviews.apache.org/r/53082/.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51031/#review153455
-----------------------------------------------------------


On Oct. 21, 2016, 10:14 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51031/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2016, 10:14 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, Zhengju Sha, and Jiang Yan
Xu.
> 
> 
> Bugs: MESOS-6035
>     https://issues.apache.org/jira/browse/MESOS-6035
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In some cases, we just want to get the children cgroups instead of
> retrieve descendant cgroups recursively. We added an argument to
> `cgroups::get` to indicate whether to retrieve cgroups recursively but
> made recursive retrieve the default behaviour. This patch fixed some
> incorrect `TEST_CGROUPS_ROOT` checks as well.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d 
>   src/linux/cgroups.cpp 630e2ec2d0eac2bb35488d0416883df1601224c8 
>   src/tests/containerizer/cgroups_tests.cpp 0afaec6ae948cabf1472bf01103210d8f9809cb1

> 
> Diff: https://reviews.apache.org/r/51031/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message