mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 53024: Fixed 'ROOT_CGROUPS_ParentExit' multi-digit fd issue.
Date Wed, 19 Oct 2016 18:42:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53024/#review153302
-----------------------------------------------------------



Patch looks great!

Reviews applied: [53024]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Oct. 19, 2016, 5:48 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53024/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2016, 5:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler, Artem
Harutyunyan, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-6357
>     https://issues.apache.org/jira/browse/MESOS-6357
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch is a workaround for dash (default sh for ubuntu and
> debian) multi-digit fd bug:
> https://bugs.launchpad.net/ubuntu/+source/dash/+bug/249620
> 
> The cleanup for using 'createCommandInfo()' will be included
> in a followup patch.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp c690b41f3852de035e5cc6378e7fc44d2c9a6fb9

> 
> Diff: https://reviews.apache.org/r/53024/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message