mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 52284: Implement more quota validation tests.
Date Wed, 19 Oct 2016 11:27:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52284/#review153267
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/master_quota_tests.cpp (lines 174 - 179)
<https://reviews.apache.org/r/52284/#comment222548>

    I think we can combine all role-related validation test into one, putting each case into
a separate scope, similarly to `SetRequestWithInvalidData` test.


- Alexander Rukletsov


On Sept. 26, 2016, 9:58 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52284/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 9:58 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Xiaojian Huang.
> 
> 
> Bugs: MESOS-4941
>     https://issues.apache.org/jira/browse/MESOS-4941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implement more quota validation tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp 48be7406181646c8cc1d169b82a4a4ca71cdf03b 
> 
> Diff: https://reviews.apache.org/r/52284/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message