mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52682: Cleaned up a few style issues in the capabilities isolator tests.
Date Tue, 18 Oct 2016 23:39:31 GMT


> On Oct. 17, 2016, 10:02 p.m., Jie Yu wrote:
> > src/tests/containerizer/linux_capabilities_isolator_tests.cpp, line 100
> > <https://reviews.apache.org/r/52682/diff/1/?file=1529586#file1529586line100>
> >
> >     const UsaImage&
> 
> Benjamin Bannier wrote:
>     I believe we always pass fundamental types like this enum by value. This one here
is almost certainly not bigger than a pointer. Can we just drop this, or would you like me
to collect a list of examples in the code base?

IC, sounds good.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52682/#review152968
-----------------------------------------------------------


On Oct. 18, 2016, 8:48 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52682/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2016, 8:48 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We remove an unused using declaration, and replace several bool
> parameters with more readable enum values.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/linux_capabilities_isolator_tests.cpp edb46659324c4c6345606cfa4c19f4fce05c59fe

> 
> Diff: https://reviews.apache.org/r/52682/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message