mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 52671: Modified the `--network_cni_plugins_dir` flag.
Date Fri, 14 Oct 2016 16:01:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52671/
-----------------------------------------------------------

(Updated Oct. 14, 2016, 4:01 p.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
-------

Addressed Jie's comments.


Bugs: MESOS-6344
    https://issues.apache.org/jira/browse/MESOS-6344


Repository: mesos


Description
-------

The `--network_cni_plugins_dir` was initially designed to take in a
single directory where all the CNI plugins were expected to be
present. This however is limiting since the operator will have to
ensure that all 3rd party plugins are installed in the same location
which a very hard constraint.

To make things simpler we are therefore converting the
`--network_cni_plugins_dir` from a single directory into a search
path.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 1b22b28825e8160f659c3cbac37cc576f01666d5

  src/slave/flags.cpp 7f79cfcc7939680c38a3d0cd57471cc9976aff7c 

Diff: https://reviews.apache.org/r/52671/diff/


Testing
-------

make, make check and sudo ./bin/mesos-tests.sh --gtest_filter=Cni*

Also ran a single node cluster and tested the flags by moving the bridge plugin from directory
to another.


Thanks,

Avinash sridharan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message