-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52864/#review152669
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On Oct. 14, 2016, 12:35 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52864/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2016, 12:35 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and haosdent huang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After we have refactored the HealthChecker into a library from the
> binary, there is no more need to wait before failing the promise to
> ensure the message has been sent to the executor. HealthChecker
> lifetime is managed by an executor, hence it is their responsibility
> not to clean the instance until after the message with the `kill_task`
> flag is received.
>
>
> Diffs
> -----
>
> src/health-check/health_checker.cpp 96ae1a733ff3d211b84d0893b4603873af1c89f0
>
> Diff: https://reviews.apache.org/r/52864/diff/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/52873/.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
|