mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 52854: Fixed the sandbox owner for command tasks.
Date Fri, 14 Oct 2016 03:36:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52854/
-----------------------------------------------------------

Review request for mesos and Gilbert Song.


Bugs: MESOS-6391
    https://issues.apache.org/jira/browse/MESOS-6391


Repository: mesos


Description
-------

If the task has a rootfs, the command executor will be run under root
because it needs to perform pivot_root. Prior to this patch, if the
task wants to run under an unprivileged user, the sandbox of that task
will not be writable because it's owned by root.

This patch fixed the issue (MESOS-6391). The command executor now
changes the owner (non-recursively) of the sandbox to match that of
the task when rootfs is specified for the task.


Diffs
-----

  src/launcher/posix/executor.cpp fdee17c5e19b94c350ee192522087051d9c9fe74 

Diff: https://reviews.apache.org/r/52854/diff/


Testing
-------

sudo make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message