mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 52251: Added test cases for TCP health check.
Date Thu, 13 Oct 2016 18:34:49 GMT


> On Oct. 13, 2016, 3:02 p.m., Gastón Kleiman wrote:
> > src/tests/health_check_tests.cpp, line 1679
> > <https://reviews.apache.org/r/52251/diff/12/?file=1532687#file1532687line1679>
> >
> >     This test is flaky, because the master will sometimes not listen on 127.0.0.1.
> >     
> >     I think that this test should use `nc` like the Docker tests.

Let's discuss at https://reviews.apache.org/r/52250/


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52251/#review152507
-----------------------------------------------------------


On Oct. 12, 2016, 2:37 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52251/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 2:37 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Gastón Kleiman.
> 
> 
> Bugs: MESOS-6279
>     https://issues.apache.org/jira/browse/MESOS-6279
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test cases for TCP health check.
> 
> 
> Diffs
> -----
> 
>   src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522 
> 
> Diff: https://reviews.apache.org/r/52251/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message