mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52741: Added capabilities support to mesos-execute.
Date Wed, 12 Oct 2016 05:43:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52741/#review152272
-----------------------------------------------------------




src/cli/execute.cpp (line 298)
<https://reviews.apache.org/r/52741/#comment221197>

    Why string? Can this be `Option<CapabilityInfo>`?



src/cli/execute.cpp (lines 961 - 963)
<https://reviews.apache.org/r/52741/#comment221198>

    ```
    foreach (const ...
             frameworkCapabilities) {
    }
    ```



src/cli/execute.cpp (lines 980 - 1001)
<https://reviews.apache.org/r/52741/#comment221200>

    You probably don't need this.



src/cli/execute.cpp (lines 1064 - 1084)
<https://reviews.apache.org/r/52741/#comment221203>

    Why this is not part of `getContainerInfo`?


- Jie Yu


On Oct. 11, 2016, 4:12 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52741/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2016, 4:12 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5303
>     https://issues.apache.org/jira/browse/MESOS-5303
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change introduces a flags `capabilities` to mesos-execute which
> can be used to specify the capabilities a task should be able to
> aquire.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp fcf627b0dcbedd01700cc8c9acadf7ba0dae4faa 
> 
> Diff: https://reviews.apache.org/r/52741/diff/
> 
> 
> Testing
> -------
> 
> * `make check`, including `ROOT` tests,
> * tested as root with a `ping` task with an agent where both the task and the agent have
different or no capabilities configured.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message