mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 50675: Libprocess: Enabled tests that pass on Windows.
Date Tue, 11 Oct 2016 23:49:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50675/
-----------------------------------------------------------

(Updated Oct. 11, 2016, 11:49 p.m.)


Review request for mesos, Daniel Pravat and Joseph Wu.


Repository: mesos


Description
-------

A large number of libprocess test files are currently not being built on
Windows. Many of these files contain tests for parts of libprocess that
have already been ported, or require only trivial fixes to work (such as
removing `#include`s on Windows). A small minority of the tests contain
bugs that we should fix.

This commit will add these files to the build, fix some of the
trivially-fixable tests, and disable tests that are known to fail
because of bugs, including comments explaining why and links to JIRA
issues where appropriate.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/CMakeLists.txt c267117ab422310854d492493d711039b287d7e3 
  3rdparty/libprocess/src/tests/future_tests.cpp 383d260a4c0b17e9a0b5af002bb35070e3ec0b01

  3rdparty/libprocess/src/tests/http_tests.cpp 8d6c8c4507b93dd11f927bad2a8f0faeb957e388 
  3rdparty/libprocess/src/tests/limiter_tests.cpp 71a3d25d4040de9b0d3eb23612be80599f4b6a9a

  3rdparty/libprocess/src/tests/metrics_tests.cpp 88526e67a20b7b58a6e14034215faa3ae9879fd0

  3rdparty/libprocess/src/tests/process_tests.cpp 3936f47dfcacb0f85a6fa0f68f1707159b1c320c

  3rdparty/libprocess/src/tests/time_tests.cpp 9d40eaee046eaa43199bb92a54892207e9c31ef2 

Diff: https://reviews.apache.org/r/50675/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message