mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.
Date Tue, 11 Oct 2016 06:21:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52563/
-----------------------------------------------------------

(Updated Oct. 11, 2016, 6:21 a.m.)


Review request for mesos, Alexander Rukletsov and Gastón Kleiman.


Changes
-------

Address @alexr's comments.


Repository: mesos


Description (updated)
-------

* Replace `Testing` to `Tests` in comments.
* Remove redundant `.Times(1)`.
* Fix typos.


Diffs (updated)
-----

  src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522 

Diff: https://reviews.apache.org/r/52563/diff/


Testing
-------

```
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*HealthCheckTest.*" --gtest_also_run_disabled_tests
[----------] Global test environment tear-down
[==========] 19 tests from 1 test case ran. (35264 ms total)
[  PASSED  ] 19 tests.
```


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message