mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.
Date Mon, 10 Oct 2016 19:33:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52620/#review152054
-----------------------------------------------------------


Ship it!




LGTM

- Anand Mazumdar


On Oct. 10, 2016, 7:18 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52620/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 7:18 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-4948
>     https://issues.apache.org/jira/browse/MESOS-4948
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated InverseOffers* maintenance tests to use the new scheduler mock.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_maintenance_tests.cpp 77eb405ab7314da906bed9ec1d0018c24928d8d8 
> 
> Diff: https://reviews.apache.org/r/52620/diff/
> 
> 
> Testing
> -------
> 
> Tested on OS X 10.11 and Ubuntu 14.04.
> ```
> make check GTEST_FILTER='MasterMaintenanceTest.*' GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1
> ```
> Noticed a segfault caused by getenv / setenv race (MESOS-3475), but it's unrelated to
this change and is reproducible on current master.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message