mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 51877: Updated comments for += and -= `Resource_` object.
Date Thu, 06 Oct 2016 00:52:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51877/#review151612
-----------------------------------------------------------


Ship it!




Looks like the review summary is a bit inaccurate? This documents `add` and `subtract`.


include/mesos/resources.hpp (line 505)
<https://reviews.apache.org/r/51877/#comment220048>

    We try to have newlines between comment paragraphs.


- Benjamin Mahler


On Sept. 15, 2016, 9:13 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51877/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 9:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The API for += and -= `Resource` object are now removed, we should
> update the comments for  += and -= `Resource_` object by telling
> end user `Resource` objects are implicitly converted to `Resource_`
> objects.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 7ba422d57d47777e058c682df9aa780557782423 
>   include/mesos/v1/resources.hpp add48c7baf8fabf5cc443d60a6c96d2902fc67de 
> 
> Diff: https://reviews.apache.org/r/51877/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message