mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 52251: Added test case `HealthCheckTest.HealthyTaskViaTCP`.
Date Wed, 05 Oct 2016 12:34:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52251/#review151490
-----------------------------------------------------------




src/tests/health_check_tests.cpp (line 1474)
<https://reviews.apache.org/r/52251/#comment219906>

    s/Testing/Tests



src/tests/health_check_tests.cpp (lines 1482 - 1483)
<https://reviews.apache.org/r/52251/#comment219907>

    Not sure we need this.



src/tests/health_check_tests.cpp (line 1495)
<https://reviews.apache.org/r/52251/#comment219908>

    This is redundant AFAIK.


- Alexander Rukletsov


On Sept. 29, 2016, 5:43 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52251/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 5:43 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test case `HealthCheckTest.HealthyTaskViaTCP`.
> 
> 
> Diffs
> -----
> 
>   src/tests/health_check_tests.cpp 5702f452d1ed9add4fdf85dd641b86aec56d29a3 
> 
> Diff: https://reviews.apache.org/r/52251/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message