mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 52034: Disabled error dialog in WebUI when user is unauthorized to see metrics.
Date Tue, 04 Oct 2016 23:56:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52034/#review151428
-----------------------------------------------------------


Ship it!




LGTM, although I'm no JS expert.


src/webui/master/static/js/controllers.js (lines 404 - 406)
<https://reviews.apache.org/r/52034/#comment219759>

    Anything else we'd want to do instead for unauthorized users? I guess we'll just show
empty/zero cluster metrics? That's better than the continuous error dialog at least.


- Adam B


On Sept. 19, 2016, 6:45 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52034/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 6:45 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Disables the dialog showing a connection error in the WebUI if the
> returned error code is either _401 Unauthorized_ or _403 Forbidden_.
> 
> Showing a connection error is missleading in the latter cases, while
> it also rendered the WebUI unusable since the dialog would show
> over and over again.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4

> 
> Diff: https://reviews.apache.org/r/52034/diff/
> 
> 
> Testing
> -------
> 
> manual tests and `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message