mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.
Date Fri, 30 Sep 2016 23:12:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52446/#review151102
-----------------------------------------------------------




src/slave/containerizer/mesos/paths.cpp (lines 146 - 149)
<https://reviews.apache.org/r/52446/#comment219234>

    termination could be None, right? Calling error will an assertion failure.


- Jie Yu


On Sept. 30, 2016, 11:08 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52446/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2016, 11:08 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-6287
>     https://issues.apache.org/jira/browse/MESOS-6287
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, when a nested container was being destroyed, it's runtime
> directory was being deleted (just the same as a top-level container).
> However, this meant that calling 'wait()' on a previously terminated
> nested container would return 'None()' since its status had already
> been reaped. The problem with this, however, is that this will cause
> an entire pod to be terminated since it thinks that the container it
> is calling wait on cannot be found.
> 
> To fix this, we leave the runtime directory of nested containers
> around until their top-level containers are destroyed. Additionally,
> we checkpiont the entire termination state of the nested container
> into its runtime directory, so that subsequent calls to 'wait()' can
> retrieve the full termination state for the lifetime of the top-level
> container.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am f093000e0282a8d5ac17e7ba33711690ccdfe68a 
>   src/slave/containerizer/mesos/containerizer.cpp 522d2c37229b07b66a0824c3e246c32f8d803b10

>   src/slave/containerizer/mesos/paths.hpp 1051c219c55253d03199045b6d2f43377ae93e53 
>   src/slave/containerizer/mesos/paths.cpp 6c6b4dcc39fbc00485552caab88457918e622e08 
>   src/tests/containerizer/nested_container_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52446/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message