mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.
Date Fri, 30 Sep 2016 06:42:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52311/#review150992
-----------------------------------------------------------



Bad patch!

Reviews applied: [52311]

Failed command: ./support/apply-review.sh -n -r 52311

Error:
2016-09-30 06:41:55 URL:https://reviews.apache.org/r/52311/diff/raw/ [2768/2768] -> "52311.patch"
[1]
error: patch failed: src/slave/slave.cpp:4368
error: src/slave/slave.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/15459/console

- Mesos ReviewBot


On Sept. 29, 2016, 6:51 p.m., Sivaram Kannan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52311/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 6:51 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5856
>     https://issues.apache.org/jira/browse/MESOS-5856
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Set the executorInfo user before the custom executor code flow.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 7073be44eab6187390922a74cf72facc29bf2ad4 
> 
> Diff: https://reviews.apache.org/r/52311/diff/
> 
> 
> Testing
> -------
> 
> 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs
are getting rotated. 
> 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting
rotated.
> 
> 
> Thanks,
> 
> Sivaram Kannan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message