mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 52374: Fixed a CHECK failure in Mesos containerizer recover.
Date Thu, 29 Sep 2016 00:42:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52374/
-----------------------------------------------------------

Review request for mesos and Gilbert Song.


Bugs: MESOS-6270
    https://issues.apache.org/jira/browse/MESOS-6270


Repository: mesos


Description
-------

It is possible that 'destroy' is called before the parent/child
relationship being properly setup. This is because we call
'container->status->onAny(reaped)` while recovering containers. Since
'recover' is asynchronous, 'reaped' might be called in the middle,
leading to 'destory' being called.

This patch defer the registration of 'reaped' callback until
parent/child relationship are properly setup.


Diffs
-----

  src/slave/containerizer/mesos/containerizer.cpp d38de1f48aab2f2932ffa8fbca77eb0290e4f143


Diff: https://reviews.apache.org/r/52374/diff/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message