mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52210: Fixed warnings in getcwd.hpp.
Date Thu, 29 Sep 2016 00:32:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52210/#review150791
-----------------------------------------------------------




3rdparty/stout/include/stout/os/getcwd.hpp (line 27)
<https://reviews.apache.org/r/52210/#comment218851>

    This doesn't seem correct.
    
    `getcwd()` on Posix is:
    ```
    char *getcwd(char *buf, size_t size);
    ```
    
    On Windows:
    ```
    char *_getcwd(char *buffer, int maxlen);
    ```
    
    So we should be changing the `getcwd()` wrapper in `stout/windows.hpp`.


- Joseph Wu


On Sept. 22, 2016, 9:48 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52210/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 9:48 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed warnings in getcwd.hpp.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/getcwd.hpp 63ecc98326a4ba9d78eb0bcec18407c3f4a76de3

> 
> Diff: https://reviews.apache.org/r/52210/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message