mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52285: Added 'volume/sandbox_path' isolator.
Date Tue, 27 Sep 2016 19:22:52 GMT


> On Sept. 27, 2016, 12:31 a.m., Joseph Wu wrote:
> > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp, lines 176-183
> > <https://reviews.apache.org/r/52285/diff/1/?file=1510517#file1510517line176>
> >
> >     Is upwards traversal allowed here?  (Should we validate?)
> 
> Jie Yu wrote:
>     I have a TODO above.

Will follow up with a validation patch (src/common/validation) to validate Volume. Right now,
I added TODO and check for dot at least.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52285/#review150491
-----------------------------------------------------------


On Sept. 26, 2016, 11:16 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52285/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 11:16 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Joseph Wu.
> 
> 
> Bugs: MESOS-6258
>     https://issues.apache.org/jira/browse/MESOS-6258
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 'volume/sandbox_path' isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 981b36e55785b9de00a79693d5b25fe66fccb710 
>   src/Makefile.am 410b5f2e5bc50a5aa7856645c8cf4a3e43505a84 
>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52285/diff/
> 
> 
> Testing
> -------
> 
> To be added. Wait for the nested container support.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message