mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 52290: Removed resources field from LaunchNestedContainer agent::Call.
Date Tue, 27 Sep 2016 00:10:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52290/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone.


Bugs: MESOS-6241
    https://issues.apache.org/jira/browse/MESOS-6241


Repository: mesos


Description
-------

This field is currently not used, in that nested containers will
share the resources allocated to the parent container, regardless
of whether resources are specified.

In the future when we introduce the ability to provide nested
container resource allocation and isolation, we can re-introduce
the field as necessary.


Diffs
-----

  include/mesos/agent/agent.proto 3397c4177813252b777bbe328ff92c9428366b70 
  include/mesos/v1/agent/agent.proto 93c817c0be92f68dea28a9272ac034386ade02af 
  src/slave/containerizer/containerizer.hpp 47a8582f37c0fc9fb0d8cb8a0b979802f603b25f 
  src/slave/containerizer/mesos/containerizer.hpp cf0ec671c1af7450c2eb44a899c98dbf403a76b1

  src/slave/containerizer/mesos/containerizer.cpp a88e4039da7319bc5b6c4003b67ef7c23ad5c320

  src/slave/http.cpp 349d307284809353d950c6f281aa8605eb9289e9 
  src/tests/api_tests.cpp e857b17cfe5f05d59859263c025564d33700a26c 
  src/tests/containerizer/mock_containerizer.hpp 840c51148399d2d2ebfb59106c1732ed5e91e61e


Diff: https://reviews.apache.org/r/52290/diff/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message