mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 52165: Disabled default executor tests for now.
Date Mon, 26 Sep 2016 22:01:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52165/#review150466
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Sept. 25, 2016, 10:06 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52165/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2016, 10:06 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6227
>     https://issues.apache.org/jira/browse/MESOS-6227
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is just a temporary set up to make the ReviewBot happy.
> Eventually, when the launcher changes land and we are able to
> launch child containers these tests would pass!
> 
> Please note that it is currently a bit hard to unit test
> the default executor as we don't have the equivalent of
> a `MockMesosContainerizer` that actually launches an
> executor. `TestContainerizer` never launches an executor though
> we can refactor it to suport v1 executors.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 786fbe3baac3c1542b318a26363213a4a1945ddd 
> 
> Diff: https://reviews.apache.org/r/52165/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message