mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 52004: Supported docker runtime isolator to be nested aware.
Date Mon, 26 Sep 2016 20:58:32 GMT


> On Sept. 18, 2016, 2:03 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 77-82
> > <https://reviews.apache.org/r/52004/diff/1/?file=1501148#file1501148line77>
> >
> >     We can remove this. The default behavior is this.
> 
> Guangya Liu wrote:
>     There is already a patch here https://reviews.apache.org/r/49234/diff/2#index_header

Hey Guangya, thanks for the patch. I want to include your cleanup in my patch, which might
make it easier for the shepherd.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52004/#review149385
-----------------------------------------------------------


On Sept. 18, 2016, 10:30 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52004/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2016, 10:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, Kevin
Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6190
>     https://issues.apache.org/jira/browse/MESOS-6190
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported docker runtime isolator to be nested aware.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp ac0397f65bb2a675ad1eae0f7cfa95f10145fc63

>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp b589cd691ae6aacd2dcd00878e43d58f15abfe11

> 
> Diff: https://reviews.apache.org/r/52004/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message