mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 52180: Added ExitedEvents for links whose sockets fail on creation.
Date Fri, 23 Sep 2016 21:49:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52180/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Artem Harutyunyan, and Joris Van Remoortere.


Bugs: MESOS-6234
    https://issues.apache.org/jira/browse/MESOS-6234


Repository: mesos


Description
-------

When we try to link to a remote process, we will send the linkee an
`ExitedEvent` when the link is broken or if the connection fails.
This patch adds an `ExitedEvent` when the socket creation step fails.
This is logically equivalent to having the connection step fail.

Because this is an entirely unexpected case, the log level should be
a WARNING or higher.


Diffs
-----

  3rdparty/libprocess/src/process.cpp 02a192529e53479d5a163fa6a20873674b51ee2c 
  3rdparty/libprocess/src/tests/process_tests.cpp b9feec7e34cffe19e49035f8865b150f79258f54


Diff: https://reviews.apache.org/r/52180/diff/


Testing
-------

make check

3rdparty/libprocess/libprocess-tests --gtest_filter="ProcessRemoteLinkTest.RemoteLinkLeak"
--gtest_repeat=5000 --gtest_break_on_failure


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message