mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Review Request 52177: Added support for CNI networks for `--task_group`.
Date Thu, 22 Sep 2016 21:48:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52177/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Vinod Kone.


Bugs: MESOS-6096
    https://issues.apache.org/jira/browse/MESOS-6096


Repository: mesos


Description
-------

Added support for CNI networks for `--task_group`.


Diffs
-----

  src/cli/execute.cpp 79091d6dd3e09e354f6965b0da45662621297bee 

Diff: https://reviews.apache.org/r/52177/diff/


Testing
-------

make

Ran `mesos-execute` with the --task_group and --network option with the following POD definition:
{
  "tasks":[
    {
      "name" : "nginx",
      "task_id" : {"value":"nginx"},
      "agent_id": {"value" : ""},
      "resources": [{
        "name": "cpus",
        "type": "SCALAR",
        "scalar": {
          "value": 0.1
        },
        "role": "*"
      },
      {
        "name": "mem",
        "type": "SCALAR",
        "scalar": {
          "value": 128
        },
        "role": "*"
      }],
      "container" : {
        "type" : "MESOS",
        "mesos" : {
          "image" : {
            "type" : "DOCKER",
            "docker" : {
              "name" : "nginx"
            }
          }
        }
      }
    },
    {
      "name" : "redis",
      "task_id" : {"value":"redis"},
      "agent_id": {"value" : ""},
      "resources": [{
        "name": "cpus",
        "type": "SCALAR",
        "scalar": {
          "value": 0.1
        },
        "role": "*"
      },
      {
        "name": "mem",
        "type": "SCALAR",
        "scalar": {
          "value": 128
        },
        "role": "*"
              }],
      "container" : {
        "type" : "MESOS",
        "mesos" : {
          "image" : {
            "type" : "DOCKER",
            "docker" : {
              "name" : "redis"
            }
          }
        }
      }
    }
  ]
}

The pod definition doesn't do much (mesos can't launch docker containers in PODS right now),
but the pod itself is attached to a CNI network and it gets an IP address and a network name
space of its own.


Thanks,

Avinash sridharan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message