mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.
Date Thu, 22 Sep 2016 01:47:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/#review149936
-----------------------------------------------------------



Looks sane :)


3rdparty/stout/tests/os_tests.cpp (line 691)
<https://reviews.apache.org/r/52048/#comment217722>

    Let's call this variable `expected_gids`.



3rdparty/stout/tests/os_tests.cpp (line 695)
<https://reviews.apache.org/r/52048/#comment217720>

    We don't actually include `std::sort` in the headers, so this shouldn't be able to compile...
    
    Either way, you should fully qualify this function.



3rdparty/stout/tests/os_tests.cpp (line 700)
<https://reviews.apache.org/r/52048/#comment217721>

    No need to clear this vector, especially since it won't be re-used.


- Joseph Wu


On Sept. 19, 2016, 2:52 p.m., Mao Geng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52048/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 2:52 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5909
>     https://issues.apache.org/jira/browse/MESOS-5909
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed OsTest.User test failure due to gids ordering.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/os_tests.cpp c2900b8bf25b06a498c32c81bd2f8c852eb682f5 
> 
> Diff: https://reviews.apache.org/r/52048/diff/
> 
> 
> Testing
> -------
> 
> Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.
> 
> 
> Thanks,
> 
> Mao Geng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message