mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.
Date Wed, 21 Sep 2016 22:14:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50621/#review149908
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On Aug. 12, 2016, 10:02 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50621/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2016, 10:02 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, and Vinod
Kone.
> 
> 
> Bugs: MESOS-3910
>     https://issues.apache.org/jira/browse/MESOS-3910
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moves the destructor code in `HttpProxy` into the `Process::finalize`
> function.  And changes the `HttpProxy`s termination logic to 
> terminate via `UPID` which guards against double-termination.
> 
> Removes some unused initialization code, too.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 629f1644bc0a263972ec9efc41890c33f9406a34 
> 
> Diff: https://reviews.apache.org/r/50621/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> (More testing done later in the chain)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message