mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 52036: Moved user of stout's `Set` to `std::set`.
Date Tue, 20 Sep 2016 16:05:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52036/
-----------------------------------------------------------

(Updated Sept. 20, 2016, 6:05 p.m.)


Review request for mesos and Michael Park.


Changes
-------

Reorganized patches by components.


Bugs: MESOS-6159
    https://issues.apache.org/jira/browse/MESOS-6159


Repository: mesos


Description (updated)
-------

After the move to C++11 stout's `Set` offers no benefits over
`std::set`, and will be removed in a subsequent change set.


Diffs (updated)
-----

  src/linux/capabilities.hpp e3203f80ae1b5448460313e9289d3dd5fff54475 
  src/linux/capabilities.cpp abaf7218a449177369dcc3f55223b678e3112271 
  src/log/log.cpp be511d9a233a663cc29014536284d26737947c15 
  src/slave/containerizer/mesos/launch.cpp fc51e04ec1572679e6a48ff4f0fa31ef2dfd6ec3 
  src/tests/containerizer/capabilities_test_helper.cpp 4c617bfc3e2a3212f7b18303b5bf7823161cb4af

  src/tests/containerizer/capabilities_tests.cpp 3ba46404c389385e02d2a1789e33dab3e8f15902


Diff: https://reviews.apache.org/r/52036/diff/


Testing
-------

`make check` in various environments


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message