mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 52080: Replaced `Latch*` with `Latch` in executor, scheduler drivers.
Date Tue, 20 Sep 2016 10:32:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52080/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

The executor and scheduler drivers previously used a `process::Latch*`
field, pointing to heap-allocated storage. This field wasn't initialized
in all code paths, leading to a Coverity static analysis warning. Using
`process::Latch` instead is safer and slightly faster.


Diffs
-----

  include/mesos/executor.hpp 10be62a86627e3157e8f439b03e139c486e8b161 
  include/mesos/scheduler.hpp 423235a90166e71866a88baa3bf16ba551010c5c 
  src/exec/exec.cpp c1cda5aca81dd8c73c50dd01ce49ef69805bbf09 
  src/sched/sched.cpp 6a1a201202b8241e853a821ffcec49187a5bdf35 

Diff: https://reviews.apache.org/r/52080/diff/


Testing
-------

`make check` on OSX.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message