mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 51985: Waited for agent finish registering in test case.
Date Mon, 19 Sep 2016 19:27:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51985/#review149534
-----------------------------------------------------------




src/tests/slave_recovery_tests.cpp (lines 4073 - 4081)
<https://reviews.apache.org/r/51985/#comment217182>

    This change doesn't seem necessary, as waiting for an offer includes waiting for the agent
to (re)register.
    
    Ditto for the below `AWAIT`s.


- Joseph Wu


On Sept. 17, 2016, 8:41 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51985/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2016, 8:41 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6180
>     https://issues.apache.org/jira/browse/MESOS-6180
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Waited for agent finish registering in test case.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 23cf9d8cd76d568fa841817d6f4279c4aa2fdc75 
> 
> Diff: https://reviews.apache.org/r/51985/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message