mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 51870: Added a test for reservation info in the agent's endpoint.
Date Mon, 19 Sep 2016 17:41:17 GMT


> On Sept. 18, 2016, 11:35 a.m., Anindya Sinha wrote:
> > src/tests/reservation_endpoints_tests.cpp, line 1671
> > <https://reviews.apache.org/r/51870/diff/1/?file=1498577#file1498577line1671>
> >
> >     This test verifies the keys `reserved_resources` as well as `reserved_resources_full`,
and there is an existing test in `slave_tests.cpp` that includes a test for the key `resources`.
> >     Can we add check for the newly added in key agent's `/state` endpoint, ie. `unreserved_resources`?

For `resources`, yes: SlaveTest.StateEndpoint

For `unreserved_resources`, I'll add to this test.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51870/#review149376
-----------------------------------------------------------


On Sept. 14, 2016, 11:21 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51870/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 11:21 a.m.)
> 
> 
> Review request for mesos, Anindya Sinha and Neil Conway.
> 
> 
> Bugs: MESOS-6085
>     https://issues.apache.org/jira/browse/MESOS-6085
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test for reservation info from the agent's endpoint.
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_endpoints_tests.cpp bee5ea6b3a3ee7fafb7312a6d89de79d62c57ec1

> 
> Diff: https://reviews.apache.org/r/51870/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message