mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Review Request 52034: Disabled error dialog in WebUI when user is unauthorized to see metrics.
Date Mon, 19 Sep 2016 13:45:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52034/
-----------------------------------------------------------

Review request for mesos and Adam B.


Repository: mesos


Description
-------

Disables the dialog showing a connection error in the WebUI if the
returned error code is either _401 Unauthorized_ or _403 Forbidden_.

Showing a connection error is missleading in the latter cases, while
it also rendered the WebUI unusable since the dialog would show
over and over again.


Diffs
-----

  src/webui/master/static/js/controllers.js 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 

Diff: https://reviews.apache.org/r/52034/diff/


Testing
-------

manual tests and `make check`


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message